Support decimal and time data types #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
is there something blocking this @tdcmeehan ? |
|
@m1n0 can you please ask for help in the PrestoDB Slack to get this PR moving? I am not a Python expert, but I can help provide a surface review later. |
|
thanks for the comment @tdcmeehan ! I already did that when I opened the PR, I just asked again now. |
|
I can deploy a cluster in AWS and let you try this out. |
|
hi, what can I do to move this forward? |
Please run some BAT tests to make sure the new updates work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is roughly a copy of what Trino did here trinodb/trino-python-client#160 - with two exceptions: